[PATCH] D38361: [ELF] Stop setting output section size early

[James Henderson via Phabricator via llvm-commits]

jhenderson updated this revision to Diff 118217.
jhenderson added a comment.

1. Reworked when assignAddresses and applySynthetic are called with regards to the MIPS GOT section, so that it has access to the right variables. This allows me to get rid of the estimating of sizes, so is more correct.
2. Delayed setting the DT_MIPS_LOCAL_GOTNO tag until a new postThunkContents for DynamicSection (thanks for the suggestion @peter.smith).
3. Removed unnecessary references to string table sections when calling postThunkContents, since they do not implement this function.
4. Removed the finalizeContents implementation for MIPS GOT since it does not do anything useful any more (previously it only called updateAllocSize, but too early to be useful).
5. Updated the SHF_LINK_ORDER-related changes that are in the latest version of https://reviews.llvm.org/D38687.
6. Fixed the line breaks in a comment in the area I was changing.


https://reviews.llvm.org/D38361

Files:
  ELF/InputSection.h
  ELF/OutputSections.cpp
  ELF/OutputSections.h
  ELF/SyntheticSections.cpp
  ELF/SyntheticSections.h
  ELF/Writer.cpp
  test/ELF/linkerscript/unused-synthetic.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38361.118217.patch
Type: text/x-patch
Size: 7970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171009/eb116c64/attachment.bin>