[PATCH] D38361: [ELF] Stop setting output section size early

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1162-1164
+    // The number of local got entries has not yet been determined. This value
+    // will be updated in postThunkContents().
+    add({DT_MIPS_LOCAL_GOTNO, uint64_t(0)});
----------------
Add blank lines before and after this so that it is clear which code this comment is talking about.


================
Comment at: ELF/SyntheticSections.cpp:1180
 
+template <class ELFT> void DynamicSection<ELFT>::postThunkContents() {
+  if (!InX::MipsGot)
----------------
Is there any way other than backfilling DT_MIPS_LOCAL_GOTNO?

For example, .eh_frame_hdr depends on .eh_frame, and that dependency is handled simply by calling .eh_frame's writeTo before .eh_frame_hdr's writeTo. Unless there is a circular dependency, you don't need to backfill a value.


https://reviews.llvm.org/D38361