[PATCH] D38315: [ARM] Add f16 type support and code generation (part 1/2)

[Sam Parker via Phabricator via llvm-commits]

samparker added a comment.

Hi Sjoerd,

Just one inline comment from me, but this approach looks good to me.

cheers,
sam



================
Comment at: lib/Target/ARM/ARMCallingConv.td:24
     
-  CCIfType<[i1, i8, i16], CCPromoteToType<i32>>,
+  CCIfType<[i1, i8, i16, f16], CCPromoteToType<i32>>,
 
----------------
should this use CCBitConvertToType instead, as you've done for the return values?


================
Comment at: lib/Target/ARM/ARMCallingConv.td:127
 
-  CCIfType<[i1, i8, i16], CCPromoteToType<i32>>,
+  CCIfType<[i1, i8, i16, f16], CCPromoteToType<i32>>,
 
----------------
Same as above.


https://reviews.llvm.org/D38315