[PATCH] D38298: A logic to copy LLVM licences into docker images.

[Ilya Biryukov via Phabricator via llvm-commits]

ilya-biryukov added inline comments.


================
Comment at: utils/docker/scripts/build_install_llvm.sh:200
+  --target "$LICENCES_DIR" \
+  --llvm_path "$CLANG_BUILD_DIR/src" --multi_dir
+
----------------
klimek wrote:
> Somewhat unrelated, but I just noticed this - if we're more pieces from LLVM than Clang in that directory, perhaps call it LLVM_BUILD_DIR? (different patch is obviously fine)
Makes sense, will do in a separate commit.


================
Comment at: utils/docker/scripts/llvm_checksum/collect_licenses.py:1
+"""A script to copy all licences of LLVM checkout.
+"""
----------------
klimek wrote:
> Isn't that actually the same as
> find . -iname '*license*' |while read f; do mkdir -p "$TARGET_DIR/$(dirname "$f")" && cp "$f" "$TARGET_DIR/$f" ; done
> 
Almost.
LLVM also embeds some licences into the source tree (MD5, Copyright.regex).
I was initially thinking of parsing references to other licences inside `LICENSE.txt`, so I chose Python. But then decided to go with hard-coded list of files for now.

Python is probably too much for this, will replace with a bash script :-)


https://reviews.llvm.org/D38298