[PATCH] D38298: A logic to copy LLVM licences into docker images.

[Manuel Klimek via Phabricator via llvm-commits]

klimek added inline comments.


================
Comment at: utils/docker/scripts/build_install_llvm.sh:200
+  --target "$LICENCES_DIR" \
+  --llvm_path "$CLANG_BUILD_DIR/src" --multi_dir
+
----------------
Somewhat unrelated, but I just noticed this - if we're more pieces from LLVM than Clang in that directory, perhaps call it LLVM_BUILD_DIR? (different patch is obviously fine)


================
Comment at: utils/docker/scripts/llvm_checksum/collect_licenses.py:1
+"""A script to copy all licences of LLVM checkout.
+"""
----------------
Isn't that actually the same as
find . -iname '*license*' |while read f; do mkdir -p "$TARGET_DIR/$(dirname "$f")" && cp "$f" "$TARGET_DIR/$f" ; done



https://reviews.llvm.org/D38298