[PATCH] D38088: Fix out-of-order stepping behavior in programs with hoisted constants.

[David Blaikie via llvm-commits]

On Thu, Sep 21, 2017 at 4:56 PM Paul Robinson via Phabricator <
reviews at reviews.llvm.org> wrote:

> probinson accepted this revision.
> probinson added a comment.
> This revision is now accepted and ready to land.
>
> Well then!  LGTM.
>
> In https://reviews.llvm.org/D38088#878342, @echristo wrote:
>
> > I mean, I disagree with the general behavior, but I think I've lost that
> argument so if it's consistent go ahead with it :)
>
>
> I am not super excited about the tactic either, but preserving the line
> info on instructions that get moved around like this is messing up an
> important consumer (SPGO) so I'm willing to tolerate it until we can come
> up with something better.
>

If this is motivated by SPGO issues - should it be using
mergeDebugLocations, then (& thus only changing the location if they come
from different basic blocks)?


>
>
> https://reviews.llvm.org/D38088
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170922/93baaab0/attachment.html>