[PATCH] D38088: Fix out-of-order stepping behavior in programs with hoisted constants.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 16:56:31 PDT 2017


probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

Well then!  LGTM.

In https://reviews.llvm.org/D38088#878342, @echristo wrote:

> I mean, I disagree with the general behavior, but I think I've lost that argument so if it's consistent go ahead with it :)


I am not super excited about the tactic either, but preserving the line info on instructions that get moved around like this is messing up an important consumer (SPGO) so I'm willing to tolerate it until we can come up with something better.


https://reviews.llvm.org/D38088





More information about the llvm-commits mailing list