[PATCH] D37791: [XRay][CodeGen] Use the current function symbol as the associated symbol for the instrumentation map

[Dean Michael Berris via llvm-commits]

> On 13 Sep 2017, at 23:20, Dean Michael Berris <dberris at google.com> wrote:
> 
>> 
>> On 13 Sep 2017, at 23:13, David Blaikie <dblaikie at gmail.com <mailto:dblaikie at gmail.com>> wrote:
>> 
>> 
>> 
>> On Wed, Sep 13, 2017 at 10:52 PM Dean Michael Berris via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
>> dberris updated this revision to Diff 115167.
>> dberris edited the summary of this revision.
>> dberris added reviewers: dblaikie, echristo.
>> dberris added a comment.
>> Herald added a subscriber: JDevlieghere.
>> 
>> Reworded description, added a test.
>> 
>> 
>> https://reviews.llvm.org/D37791 <https://reviews.llvm.org/D37791>
>> 
>> Files:
>>   lib/CodeGen/AsmPrinter/AsmPrinter.cpp
>>   test/DebugInfo/X86/xray-split-dwarf-interaction.ll
>> 
>> 
>> Index: test/DebugInfo/X86/xray-split-dwarf-interaction.ll
>> ===================================================================
>> --- /dev/null
>> +++ test/DebugInfo/X86/xray-split-dwarf-interaction.ll
>> @@ -0,0 +1,76 @@
>> +; RUN: %llc_dwarf -split-dwarf-file=input.dwo -O3 -function-sections -data-sections \
>> +; RUN:     -relocation-model=pic -filetype=obj -generate-type-units -debug-compile -o %t %s
>> 
>> Have you tried this without fission/split-dwarf? I imagine it still reproduces (I think it's only type units that are important?)
>>  
> 
> Not yet, but this was the case that caused the issues that I can reproduce. I can add another build here too.
> 

Actually, the "bug" wouldn't be fatal in that case, since we'd just have the wrong association. It's only when the debug section is stripped in case of split-dwarf that objcopy complains.

Landing this now, we can iterate more on it later.

Thanks for the reviews!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170913/d62e34ee/attachment.html>