<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On 13 Sep 2017, at 23:20, Dean Michael Berris <<a href="mailto:dberris@google.com" class="">dberris@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: HelveticaNeue; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" class=""><div class=""><br class="Apple-interchange-newline">On 13 Sep 2017, at 23:13, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Sep 13, 2017 at 10:52 PM Dean Michael Berris via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">dberris updated this revision to Diff 115167.<br class="">dberris edited the summary of this revision.<br class="">dberris added reviewers: dblaikie, echristo.<br class="">dberris added a comment.<br class="">Herald added a subscriber: JDevlieghere.<br class=""><br class="">Reworded description, added a test.<br class=""><br class=""><br class=""><a href="https://reviews.llvm.org/D37791" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D37791</a><br class=""><br class="">Files:<br class=""> lib/CodeGen/AsmPrinter/AsmPrinter.cpp<br class=""> test/DebugInfo/X86/xray-split-dwarf-interaction.ll<br class=""><br class=""><br class="">Index: test/DebugInfo/X86/xray-split-dwarf-interaction.ll<br class="">===================================================================<br class="">--- /dev/null<br class="">+++ test/DebugInfo/X86/xray-split-dwarf-interaction.ll<br class="">@@ -0,0 +1,76 @@<br class="">+; RUN: %llc_dwarf -split-dwarf-file=input.dwo -O3 -function-sections -data-sections \<br class="">+; RUN: -relocation-model=pic -filetype=obj -generate-type-units -debug-compile -o %t %s<br class=""></blockquote><div class=""><br class="">Have you tried this without fission/split-dwarf? I imagine it still reproduces (I think it's only type units that are important?)<br class=""> </div></div></div></div></blockquote><div class=""><br class=""></div><div class="">Not yet, but this was the case that caused the issues that I can reproduce. I can add another build here too.</div><br class=""></div></div></blockquote><div><br class=""></div><div>Actually, the "bug" wouldn't be fatal in that case, since we'd just have the wrong association. It's only when the debug section is stripped in case of split-dwarf that objcopy complains.</div><div><br class=""></div><div>Landing this now, we can iterate more on it later.<div class=""><br class=""></div><div class="">Thanks for the reviews!</div></div></div><br class=""></div></body></html>