[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

[Adrian Prantl via llvm-commits]

> On Sep 8, 2017, at 1:49 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> 
> 
> On Fri, Sep 8, 2017 at 1:47 PM Adrian Prantl via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> aprantl added a comment.
> 
> In https://reviews.llvm.org/D37602#865266 <https://reviews.llvm.org/D37602#865266>, @zturner wrote:
> 
> > I think this addresses most of the concerns raised so far.
> 
> 
> Here's a couple of concerns that were mentioned before that are outstanding:
> 
> - The Readme.txt needs to be updated, it currently states that the repository is supposed to be cloned into tools/clang/test.
> - The clang lit configuration needs to be updated to remove the debuginfo-tests-specific parts.
> - This patch is adding >300 lines of extra configuration. I still don't understand what problem this patch is solving that is worth the extra maintenance effort.
> 
> At least it's supporting the monorepo layout without adding additional local symlinks (in the same way that clang can be used in the monorepo without symlinking it from llvm/projects).
>  

That's an interesting point, thanks. That together with the promise to factor out a common lit configuration library might work to convince me :-)

-- adrian


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170908/1725d5f1/attachment.html>