[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In https://reviews.llvm.org/D37602#865313, @aprantl wrote:

> In https://reviews.llvm.org/D37602#865266, @zturner wrote:
>
> > I think this addresses most of the concerns raised so far.
>
>
> Here's a couple of concerns that were mentioned before that are outstanding:
>
> - The Readme.txt needs to be updated, it currently states that the repository is supposed to be cloned into tools/clang/test.
> - The clang lit configuration needs to be updated to remove the debuginfo-tests-specific parts.


Thanks, I'll take a look.

> - This patch is adding >300 lines of extra configuration. I still don't understand what problem this patch is solving that is worth the extra maintenance effort.

Part of what I was hoping to achieve with this code review is someone who understands clang's lit config to come along and say "oh you can delete all of this stuff, it's not necessary for this."  I also agree there's too much.  I'm currently thinking about ways to sink some of it into llvm/utils/lit, since much of it is already duplicated across multiple projects.


https://reviews.llvm.org/D37602