[PATCH] D37439: [MachO] Prevent heap overflow when load command extends past EOF

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In https://reviews.llvm.org/D37439#860575, @kcc wrote:

> Looks good (but I don't know this code). 
>  Thanks for adding the test input -- once the shallow bugs are cleaned up I'll use test/Object/Inputs/ as the seed corpus.


Thanks Kostya!

> I've run the fuzzer manually and the most frequent failure looks like this:
> 
>   LLVM ERROR: Invalid data was encountered while parsing the file
>    #7 0x560c25 in llvm::object::RelocVisitor::getELFAddend(llvm::object::RelocationRef) Object/RelocVisitor.h:120:7
>    
> 
> (and a few similar ones)
> 
> Are these something you could fix as well? 
>  W/o fixing these, fuzzing won't go deep (as it crashes almost instantly)

I'll have a look if I can find some spare time, but I'll be focussing on the Mach-O stuff mostly.


Repository:
  rL LLVM

https://reviews.llvm.org/D37439