[PATCH] D37439: [MachO] Prevent heap overflow when load command extends past EOF

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 4 14:17:50 PDT 2017


kcc added a comment.

Looks good (but I don't know this code). 
Thanks for adding the test input -- once the shallow bugs are cleaned up I'll use test/Object/Inputs/ as the seed corpus.

I've run the fuzzer manually and the most frequent failure looks like this:

  LLVM ERROR: Invalid data was encountered while parsing the file
   #7 0x560c25 in llvm::object::RelocVisitor::getELFAddend(llvm::object::RelocationRef) Object/RelocVisitor.h:120:7

(and a few similar ones)

Are these something you could fix as well? 
W/o fixing these, fuzzing won't go deep (as it crashes almost instantly)


Repository:
  rL LLVM

https://reviews.llvm.org/D37439





More information about the llvm-commits mailing list