[PATCH] D34600: [Error] add expectSuccess()

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 17:47:38 PDT 2017


Yea, sounds good
On Thu, Aug 31, 2017 at 5:22 PM Lang Hames via Phabricator <
reviews at reviews.llvm.org> wrote:

> lhames added a comment.
>
> I added an optional error message to cantFail in 312066 to make it easier
> to recognize which call failed, so the renamed API would be:
>
> Error assertSuccess(Error Err, const char *AssertMsg = nullptr)
>
> template <typename T>
> T assertSuccess(Expected<T>, const char *AssertMsg = nullptr)
>
> Sound good?
>
> Cheers,
> Lang.
>
>
> https://reviews.llvm.org/D34600
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170901/7c676c7d/attachment.html>


More information about the llvm-commits mailing list