[PATCH] D34600: [Error] add expectSuccess()

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 17:22:18 PDT 2017


lhames added a comment.

I added an optional error message to cantFail in 312066 to make it easier to recognize which call failed, so the renamed API would be:

Error assertSuccess(Error Err, const char *AssertMsg = nullptr)

template <typename T>
T assertSuccess(Expected<T>, const char *AssertMsg = nullptr)

Sound good?

Cheers,
Lang.


https://reviews.llvm.org/D34600





More information about the llvm-commits mailing list