[llvm] r311054 - [X86] Use a static array instead of a SmallVector for a small fixed size array. NFC

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 18:08:29 PDT 2017


Maybe omit the explicit array size & let it come from the init list size?

On Wed, Aug 16, 2017 at 4:17 PM Craig Topper via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: ctopper
> Date: Wed Aug 16 16:16:43 2017
> New Revision: 311054
>
> URL: http://llvm.org/viewvc/llvm-project?rev=311054&view=rev
> Log:
> [X86] Use a static array instead of a SmallVector for a small fixed size
> array. NFC
>
> Modified:
>     llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
>
> Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=311054&r1=311053&r2=311054&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Wed Aug 16 16:16:43 2017
> @@ -19130,8 +19130,8 @@ static SDValue getTargetVShiftNode(unsig
>      ShAmt = DAG.getNode(ISD::SCALAR_TO_VECTOR, SDLoc(ShAmt), MVT::v4i32,
> ShAmt);
>      ShAmt = DAG.getZeroExtendVectorInReg(ShAmt, SDLoc(ShAmt), MVT::v2i64);
>    } else {
> -    SmallVector<SDValue, 4> ShOps = {ShAmt, DAG.getConstant(0, dl, SVT),
> -                                     DAG.getUNDEF(SVT),
> DAG.getUNDEF(SVT)};
> +    SDValue ShOps[4] = {ShAmt, DAG.getConstant(0, dl, SVT),
> +                        DAG.getUNDEF(SVT), DAG.getUNDEF(SVT)};
>      ShAmt = DAG.getBuildVector(MVT::v4i32, dl, ShOps);
>    }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170829/96d41b81/attachment.html>


More information about the llvm-commits mailing list