<div dir="ltr">Maybe omit the explicit array size & let it come from the init list size?</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 16, 2017 at 4:17 PM Craig Topper via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Wed Aug 16 16:16:43 2017<br>
New Revision: 311054<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=311054&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=311054&view=rev</a><br>
Log:<br>
[X86] Use a static array instead of a SmallVector for a small fixed size array. NFC<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=311054&r1=311053&r2=311054&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=311054&r1=311053&r2=311054&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Wed Aug 16 16:16:43 2017<br>
@@ -19130,8 +19130,8 @@ static SDValue getTargetVShiftNode(unsig<br>
     ShAmt = DAG.getNode(ISD::SCALAR_TO_VECTOR, SDLoc(ShAmt), MVT::v4i32, ShAmt);<br>
     ShAmt = DAG.getZeroExtendVectorInReg(ShAmt, SDLoc(ShAmt), MVT::v2i64);<br>
   } else {<br>
-    SmallVector<SDValue, 4> ShOps = {ShAmt, DAG.getConstant(0, dl, SVT),<br>
-                                     DAG.getUNDEF(SVT), DAG.getUNDEF(SVT)};<br>
+    SDValue ShOps[4] = {ShAmt, DAG.getConstant(0, dl, SVT),<br>
+                        DAG.getUNDEF(SVT), DAG.getUNDEF(SVT)};<br>
     ShAmt = DAG.getBuildVector(MVT::v4i32, dl, ShOps);<br>
   }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>