[PATCH] D37118: [ARM] Tidy-up ARMAsmParser. NFC.

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 11:43:06 PDT 2017


javed.absar added a comment.

In https://reviews.llvm.org/D37118#852732, @fhahn wrote:

> Would it be possible to just used `MRI->getSubReg(QReg, ARM::dsub_0)` wherever `getDRegFromQReg` is called? It does not seem like having a  getDRegFromQReg function adds much value now.


I count 8 instance of it being called, so woulld really prefer a separate function for clarity and let the compiler inline it.


https://reviews.llvm.org/D37118





More information about the llvm-commits mailing list