[PATCH] D37118: [ARM] Tidy-up ARMAsmParser. NFC.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 13:13:23 PDT 2017


asb added a comment.

Looks good to me. I agree it seems almost unnecessary to have a helper for `MRI->getSubReg(QReg, ARM::dsub_0)`, but as Javed points out it's called many times and getDRegFromQReg is much more readable.


https://reviews.llvm.org/D37118





More information about the llvm-commits mailing list