[lld] r311536 - [ELF] - Repair dynsym-pie.s testcase.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 01:42:35 PDT 2017


Author: grimar
Date: Wed Aug 23 01:42:35 2017
New Revision: 311536

URL: http://llvm.org/viewvc/llvm-project?rev=311536&view=rev
Log:
[ELF] - Repair dynsym-pie.s testcase.

It was broken from begining, because visibility
attributes were not applied properly to
symbols before this patch.

Differential revision: https://reviews.llvm.org/D36966

Modified:
    lld/trunk/test/ELF/dynsym-pie.s

Modified: lld/trunk/test/ELF/dynsym-pie.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/dynsym-pie.s?rev=311536&r1=311535&r2=311536&view=diff
==============================================================================
--- lld/trunk/test/ELF/dynsym-pie.s (original)
+++ lld/trunk/test/ELF/dynsym-pie.s Wed Aug 23 01:42:35 2017
@@ -3,6 +3,51 @@
 # RUN: ld.lld -pie %t -o %t.out
 # RUN: llvm-readobj -t -dyn-symbols %t.out | FileCheck %s
 
+# CHECK:       Symbols [
+# CHECK:        Symbol {
+# CHECK:          Name: hidden
+# CHECK-NEXT:     Value: 0x1000
+# CHECK-NEXT:     Size: 0
+# CHECK-NEXT:     Binding: Local
+# CHECK-NEXT:     Type: None
+# CHECK-NEXT:     Other [
+# CHECK-NEXT:       STV_HIDDEN
+# CHECK-NEXT:     ]
+# CHECK-NEXT:     Section: .text
+# CHECK-NEXT:   }
+# CHECK:        Symbol {
+# CHECK:          Name: internal
+# CHECK-NEXT:     Value: 0x1000
+# CHECK-NEXT:     Size: 0
+# CHECK-NEXT:     Binding: Local
+# CHECK-NEXT:     Type: None
+# CHECK-NEXT:     Other [
+# CHECK-NEXT:       STV_INTERNAL
+# CHECK-NEXT:     ]
+# CHECK-NEXT:     Section: .text
+# CHECK-NEXT:   }
+# CHECK:        Symbol {
+# CHECK:          Name: default
+# CHECK-NEXT:     Value: 0x1000
+# CHECK-NEXT:     Size: 0
+# CHECK-NEXT:     Binding: Global
+# CHECK-NEXT:     Type: None
+# CHECK-NEXT:     Other: 0
+# CHECK-NEXT:     Section: .text
+# CHECK-NEXT:   }
+# CHECK:        Symbol {
+# CHECK:          Name: protected
+# CHECK-NEXT:     Value: 0x1000
+# CHECK-NEXT:     Size: 0
+# CHECK-NEXT:     Binding: Global
+# CHECK-NEXT:     Type: None
+# CHECK-NEXT:     Other [
+# CHECK-NEXT:       STV_PROTECTED
+# CHECK-NEXT:     ]
+# CHECK-NEXT:     Section: .text
+# CHECK-NEXT:   }
+# CHECK-NEXT: ]
+
 # CHECK:      DynamicSymbols [
 # CHECK-NEXT:  Symbol {
 # CHECK-NEXT:    Name: @
@@ -23,14 +68,13 @@ _start:
 default:
 
 .global protected
+.protected protected
 protected:
 
 .global hidden
+.hidden hidden
 hidden:
 
 .global internal
+.internal internal
 internal:
-
-.global protected_with_hidden
-.protected
-protected_with_hidden:




More information about the llvm-commits mailing list