[PATCH] D37052: Add default address space for functions to the data layout (1/4)

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Has there been an RFC on this?

Despite being a simple change, I can't foresee all the consequences. Superficially, it looks harmless, but I'd rather more people on the list could have a look at it too.



================
Comment at: lib/Target/AVR/AVRTargetMachine.cpp:28
 
-static const char *AVRDataLayout = "e-p:16:16:16-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-n8";
 
----------------
arsenm wrote:
> I think changing the AVR layout is a separate patch
Indeed. It would be easier to just revert this one change on its own if bots start break, without reverting the whole set of changes.


https://reviews.llvm.org/D37052