[PATCH] D36920: [GPGPU] Collect parameter dimension used in MemoryAccesses

[Tobias Grosser via Phabricator via llvm-commits]

grosser accepted this revision.
grosser added a comment.

Committed in r311239. I forgot to add the phab URL, hence I close it manually.



================
Comment at: lib/CodeGen/IslNodeBuilder.cpp:231
 
   for (auto &Access : *Stmt) {
+    isl::space ParamSpace = Access->getLatestAccessRelation().get_space();
----------------
bollu wrote:
> Nit: Change the `auto` to `MemoryAccess`? It would not be obvious to someone who does not work on Polly that a statement iterator gives `MemoryAccess`.
This is an unrelated change. I will do it ahead of the commit.


================
Comment at: lib/CodeGen/PPCGCodeGeneration.cpp:1446
   SubtreeReferences References = {
-      LI, SE, S, ValueMap, SubtreeValues, SCEVs, getBlockGenerator()};
+      LI,         SE, S, ValueMap, SubtreeValues, SCEVs, getBlockGenerator(),
+      &ParamSpace};
----------------
bollu wrote:
> Unintended space?
> ` LI,         SE,`
> 
> 
> 
That's a clang-format artifact. Seems the formatting choice is not totally optimal here. I leave it as it is, as I see now way to work around it.


https://reviews.llvm.org/D36920