[PATCH] D36920: [GPGPU] Collect parameter dimension used in MemoryAccesses

[Siddharth via Phabricator via llvm-commits]

bollu accepted this revision.
bollu added a comment.
This revision is now accepted and ready to land.

Thanks! Other than nits, LGTM.



================
Comment at: include/polly/CodeGen/IslNodeBuilder.h:47
   BlockGenerator &BlockGen;
+  isl::space *ParamSpace;
 };
----------------
Could you add a comment here stating why this is obvious, and maybe a `FIXME` for a nicer design? 


================
Comment at: lib/CodeGen/PPCGCodeGeneration.cpp:1446
   SubtreeReferences References = {
-      LI, SE, S, ValueMap, SubtreeValues, SCEVs, getBlockGenerator()};
+      LI,         SE, S, ValueMap, SubtreeValues, SCEVs, getBlockGenerator(),
+      &ParamSpace};
----------------
Unintended space?
` LI,         SE,`





https://reviews.llvm.org/D36920