[PATCH] D36201: Merge manifest namespaces.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/lib/WindowsManifest/WindowsManifestMerger.cpp:221
+        continue;
+      } else if (namespaceOverrides(OriginalAttribute->ns->href,
+                                    Attribute->ns->href)) {
----------------
ecbeckmann wrote:
> ruiu wrote:
> > Well, you want to remove `continue`, as I described in the previous comment. (Please fix not only this place but other places as well.)
> wait I'm confused, I thought we want to add the early continues?
Ah sorry, I meant not `continue` but `else`.


https://reviews.llvm.org/D36201