[PATCH] D36201: Merge manifest namespaces.

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 18:46:53 PDT 2017


ecbeckmann added inline comments.


================
Comment at: llvm/lib/WindowsManifest/WindowsManifestMerger.cpp:221
+        continue;
+      } else if (namespaceOverrides(OriginalAttribute->ns->href,
+                                    Attribute->ns->href)) {
----------------
ruiu wrote:
> Well, you want to remove `continue`, as I described in the previous comment. (Please fix not only this place but other places as well.)
wait I'm confused, I thought we want to add the early continues?


https://reviews.llvm.org/D36201





More information about the llvm-commits mailing list