[PATCH] D35919: [AArch64] Rewrite stack frame handling for win64 vararg functions

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 14:31:00 PDT 2017


mstorsjo updated this revision to Diff 108715.
mstorsjo retitled this revision from "[AArch64] Fix callee saved registers in win64 vararg functions with CombineSPBump=0" to "[AArch64] Rewrite stack frame handling for win64 vararg functions".
mstorsjo edited the summary of this revision.
mstorsjo added a comment.

Tim: Updated after a whole lot of more testing, testing all codepaths through the emit prologue/epilogue as far as I can see (tested both with and without a frame pointer), testing unwinding for C++ exceptions through a win64cc function, etc. Hopefully this instills a bit more confidence this time. I've included a few open questions about how to rename variables in the patch message and inline that I hope you can give your opinion on.


https://reviews.llvm.org/D35919

Files:
  lib/Target/AArch64/AArch64FrameLowering.cpp
  test/CodeGen/AArch64/aarch64_win64cc_vararg.ll
  test/CodeGen/AArch64/win64_vararg.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35919.108715.patch
Type: text/x-patch
Size: 9424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170728/5a7252a3/attachment.bin>


More information about the llvm-commits mailing list