[PATCH] D35898: [OCaml] Respect CMAKE_C_FLAGS for OCaml C files

[Michał Górny via Phabricator via llvm-commits]

mgorny added inline comments.


================
Comment at: cmake/modules/AddOCaml.cmake:86
   string(REPLACE ";" " " ARG_CFLAGS "${ARG_CFLAGS}")
-  set(c_flags "${ARG_CFLAGS} ${LLVM_DEFINITIONS}")
+  set(c_flags "${CMAKE_C_FLAGS} ${CMAKE_C_FLAGS_${uppercase_CMAKE_BUILD_TYPE}} ${ARG_CFLAGS} ${LLVM_DEFINITIONS}")
   foreach( include_dir ${LLVM_INCLUDE_DIR} ${LLVM_MAIN_INCLUDE_DIR} )
----------------
whitequark wrote:
> What is the relationship between `CMAKE_C_FLAGS*` and `LLVM_DEFINITIONS`?
I haven't investigated it closely. But I have added a `message()` here and I didn't see any duplicates between the two, if that's what you're asking about.


Repository:
  rL LLVM

https://reviews.llvm.org/D35898