[PATCH] D35898: [OCaml] Respect CMAKE_C_FLAGS for OCaml C files

whitequark via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 09:34:21 PDT 2017


whitequark added inline comments.


================
Comment at: cmake/modules/AddOCaml.cmake:86
   string(REPLACE ";" " " ARG_CFLAGS "${ARG_CFLAGS}")
-  set(c_flags "${ARG_CFLAGS} ${LLVM_DEFINITIONS}")
+  set(c_flags "${CMAKE_C_FLAGS} ${CMAKE_C_FLAGS_${uppercase_CMAKE_BUILD_TYPE}} ${ARG_CFLAGS} ${LLVM_DEFINITIONS}")
   foreach( include_dir ${LLVM_INCLUDE_DIR} ${LLVM_MAIN_INCLUDE_DIR} )
----------------
What is the relationship between `CMAKE_C_FLAGS*` and `LLVM_DEFINITIONS`?


Repository:
  rL LLVM

https://reviews.llvm.org/D35898





More information about the llvm-commits mailing list