[PATCH] D35007: [PowerPC] Do not emit displacements for DQ-Form instructions that aren't multiples of 16

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 16:15:12 PDT 2017


nemanjai updated this revision to Diff 106336.
nemanjai added a comment.

Kept the fixes to the FrameIndex issues but reverted the predicate for selecting the DQ-Form instructions to use the displacement being a multiple of 16.

As it turns out, the problem reported in the bug is much more serious and prevalent - affecting https://reviews.llvm.org/P9 code generation for most applications. This is really something we should get into the 5.0 release as we don't want to ship a release with this bug. We branch the release next Wednesday so I'm really hoping we can get this reviewed and committed by Friday of this week to give it a couple of days in trunk before we branch.

@hfinkel @echristo @kbarton I know I'm asking a lot, but would you please give this patch your prompt attention due to the prevalence of the problem and the imminence of the release branch.


Repository:
  rL LLVM

https://reviews.llvm.org/D35007

Files:
  lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp
  lib/Target/PowerPC/PPCISelDAGToDAG.cpp
  lib/Target/PowerPC/PPCISelLowering.cpp
  lib/Target/PowerPC/PPCISelLowering.h
  lib/Target/PowerPC/PPCInstrInfo.td
  lib/Target/PowerPC/PPCInstrVSX.td
  lib/Target/PowerPC/PPCRegisterInfo.cpp
  test/CodeGen/PowerPC/PR33671.ll
  test/CodeGen/PowerPC/build-vector-tests.ll
  test/CodeGen/PowerPC/ppc64-i128-abi.ll
  test/CodeGen/PowerPC/swaps-le-6.ll
  test/CodeGen/PowerPC/vsx-p9.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35007.106336.patch
Type: text/x-patch
Size: 29647 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170712/04a23e0c/attachment.bin>


More information about the llvm-commits mailing list