[PATCH] D35007: [PowerPC] Do not emit displacements for DQ-Form instructions that aren't multiples of 16

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

In https://reviews.llvm.org/D35007#805378, @nemanjai wrote:

> In https://reviews.llvm.org/D35007#805153, @hfinkel wrote:
>
> > > Although the instruction doesn't require any special alignment, allowing it to be used with weaker alignment allows other passes to modify the offset after ISEL.
> >
> > For what other passes is this true (aside from places dealing with frame indices, which it seems like you're fixing regardless)?
>
>
> I actually don't know that. I thought I had seen that before I fixed all the FrameIndex stuff, but looking back on it - it was also FI related. Do you think I should go back to the original way of testing for the displacement operand, but keep the FI fixes?


Yes. (although you should still change the name of the tablegen predicates to something that does not imply that we're checking alignments).


Repository:
  rL LLVM

https://reviews.llvm.org/D35007