[PATCH] D35199: Add an X86 AVX2 clang builder and slave

Galina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 23:17:24 PDT 2017


gkistanova accepted this revision.
gkistanova added a comment.
This revision is now accepted and ready to land.

LGTM, assuming you will remove the unrelated cosmetic changes, and figure out what place you want to specify the number of jobs. Up to me, a slave property seems a better and more natural place.



================
Comment at: buildbot/osuosl/master/config/builders.py:638
+         'factory' : ClangBuilder.getClangCMakeBuildFactory(
+             jobs=80,
+             clean=False,
----------------
eladcohen wrote:
> zvi wrote:
> > Given that we are allowing lots of jobs to run in parallel, should we be using Ninja instead of Make? It's known to scale better.
> Judging by the other buildbots that use ClangCmakeBuildFactory - It defaults to Ninja
No need to specify a number of jobs here if you did it as the slave property.



https://reviews.llvm.org/D35199





More information about the llvm-commits mailing list