[PATCH] D35199: Add an X86 AVX2 clang builder and slave

[Elad Cohen via Phabricator via llvm-commits]

eladcohen added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:634
+        ## X86_64 AVX2 Clang+LLVM check-all + test-suite
+        {'name': "clang-cmake-x86_64-avx2-linux",
+         'slavenames':["avx2-intel64"],
----------------
zvi wrote:
> does the 'clang' component in the machine name mean:
> 
>    - We are using Clang to build LLVM and Clanf
> or:
> 
> 
>   - We are building LLVM + Clang using the Ubuntu default system compiler?
> 
> 
> 
> 
We are building LLVM + Clang using the Ubuntu default system compiler.

Following the convention of all the other buildbots, the 'clang' component stands for building LLVM+Clang (Using the ClangCMakeBuildFactory) as opposed to the 'llvm' bots which build llvm without clang.


================
Comment at: buildbot/osuosl/master/config/builders.py:638
+         'factory' : ClangBuilder.getClangCMakeBuildFactory(
+             jobs=80,
+             clean=False,
----------------
zvi wrote:
> Given that we are allowing lots of jobs to run in parallel, should we be using Ninja instead of Make? It's known to scale better.
Judging by the other buildbots that use ClangCmakeBuildFactory - It defaults to Ninja


================
Comment at: buildbot/osuosl/master/config/builders.py:1121
                          env={'PATH':'/home/llvmbb/bin/clang-latest/bin:/home/llvmbb/bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin'})},
-                         
+
         {'name': "libomp-clang-ppc64le-linux-debian",
----------------
zvi wrote:
> Looks like this line + 2 below are only white-space changes.
Yes, I'm not sure why my editor added these. I'll remove them.


https://reviews.llvm.org/D35199