[PATCH] D35097: [InstCombine] Make InstCombine's IRBuilder be passed by reference everywhere

[Sanjay Patel via llvm-commits]

LGTM  (I reviewed and approved this patch yesterday, but Phab failed to
send an email to the list AFAICT.)

On Thu, Jul 6, 2017 at 5:07 PM, Craig Topper via Phabricator <
reviews at reviews.llvm.org> wrote:

> craig.topper created this revision.
>
> Previously the InstCombiner class contained a pointer to an IR builder
> that had been passed to the constructor. Sometimes this would be passed to
> helper functions as either a pointer or the pointer would be dereferenced
> to be passed by reference.
>
> This patch makes it a reference everywhere including the InstCombiner
> class itself so there is more inconsistency. This a large, but mechanical
> patch. I've done very minimal formatting changes on it despite what
> clang-format wanted to do.
>
>
> https://reviews.llvm.org/D35097
>
> Files:
>   lib/Transforms/InstCombine/InstCombineAddSub.cpp
>   lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
>   lib/Transforms/InstCombine/InstCombineCalls.cpp
>   lib/Transforms/InstCombine/InstCombineCasts.cpp
>   lib/Transforms/InstCombine/InstCombineCompares.cpp
>   lib/Transforms/InstCombine/InstCombineInternal.h
>   lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
>   lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
>   lib/Transforms/InstCombine/InstCombinePHI.cpp
>   lib/Transforms/InstCombine/InstCombineSelect.cpp
>   lib/Transforms/InstCombine/InstCombineShifts.cpp
>   lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
>   lib/Transforms/InstCombine/InstCombineVectorOps.cpp
>   lib/Transforms/InstCombine/InstructionCombining.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170708/6afcb8a0/attachment.html>