<div dir="ltr">LGTM (I reviewed and approved this patch yesterday, but Phab failed to send an email to the list AFAICT.)<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 6, 2017 at 5:07 PM, Craig Topper via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">craig.topper created this revision.<br>
<br>
Previously the InstCombiner class contained a pointer to an IR builder that had been passed to the constructor. Sometimes this would be passed to helper functions as either a pointer or the pointer would be dereferenced to be passed by reference.<br>
<br>
This patch makes it a reference everywhere including the InstCombiner class itself so there is more inconsistency. This a large, but mechanical patch. I've done very minimal formatting changes on it despite what clang-format wanted to do.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D35097" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D35097</a><br>
<br>
Files:<br>
lib/Transforms/InstCombine/<wbr>InstCombineAddSub.cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombineAndOrXor.cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombineCalls.cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombineCasts.cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombineCompares.cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombineInternal.h<br>
lib/Transforms/InstCombine/<wbr>InstCombineLoadStoreAlloca.cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombineMulDivRem.cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombinePHI.cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombineSelect.cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombineShifts.cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombineSimplifyDemanded.<wbr>cpp<br>
lib/Transforms/InstCombine/<wbr>InstCombineVectorOps.cpp<br>
lib/Transforms/InstCombine/<wbr>InstructionCombining.cpp<br>
<br>
</blockquote></div><br></div>