[PATCH] D35086: Fix some differences between LLD and MSVC generated PDBs

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/PDB.cpp:344
   InfoBuilder.setAge(DI ? DI->PDB70.Age : 0);
+  InfoBuilder.setSignature(time(nullptr));
 
----------------
rnk wrote:
> Generally speaking we want our tool output to be deterministic. Clang has a /Brepro flag that controls the emission of timestamps in file headers. Can you add a FIXME here to add a flag for this?
Actually, ignore this. We already need to absolute-ize paths, so our output isn't really deterministic.


================
Comment at: lld/test/COFF/pdb-diff.test:177
+CHECK-NEXT:   |----------------------------------------+---|
+CHECK-NEXT:   |Module "D:\src\llvm-mono\lld\test\COFF/Inputs/pdb-diff.obj"|
+CHECK-NEXT:   |----------------------------------------+---|
----------------
This isn't going to match on other people's systems.


https://reviews.llvm.org/D35086