[PATCH] D35086: Fix some differences between LLD and MSVC generated PDBs

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/PDB.cpp:344
   InfoBuilder.setAge(DI ? DI->PDB70.Age : 0);
+  InfoBuilder.setSignature(time(nullptr));
 
----------------
Generally speaking we want our tool output to be deterministic. Clang has a /Brepro flag that controls the emission of timestamps in file headers. Can you add a FIXME here to add a flag for this?


================
Comment at: lld/test/COFF/pdb-diff.test:10
+
+CHECK:        ----------------------
+CHECK-NEXT:   |  MSF Super Block   |
----------------
Are you worried about the fragility of these CHECKs? FileCheck ignores whitespace differences, so it might not be so bad, but I'm a little concerned.


https://reviews.llvm.org/D35086