[PATCH] D34923: [X86] Add comment string for broadcast loads from the constant pool.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86MCInstLower.cpp:1863-1867
+      switch (MI->getOpcode()) {
+      default: llvm_unreachable("Invalid opcode");
+      case X86::VBROADCASTSSrm:    NumElts = 4;  break;
+      case X86::VBROADCASTSSYrm:   NumElts = 8;  break;
+      case X86::VBROADCASTSSZ128m: NumElts = 4;  break;
----------------
spatel wrote:
> Could set NumElts above and then fall-through to avoid the switch-within-a-switch? Same for NumLanes below here.
How do I fallthrough with different values for NumElts without using a goto?


https://reviews.llvm.org/D34923