[PATCH] D34744: [DWARF] - Simplify HandleExpectedError implementation in DWARFDebugInfoTest

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D34744#795395, @zturner wrote:

> lgtm.  I have some other ideas for how to improve this test in the future, but mostly orthogonal to this effort (for example, why can't we just enumerate the cases that we expect to work based on the `TargetRegistry`, and then only run those tests?)
>
> Might be a nice cleanup if you feel like it (or there might be some reason I can't think of why it wouldn't work the way I imagine), but feel free to do it in a follow-up (or not at all, purely optional)


Thanks for review. Idea looks interesting for me. I am not so familar with gtest yet. I read gtest doc and reviewed implementation today, but did not yet found how to filter out tests with some custom predicate.
I see that gtest allows filtering by name, that is probably not what can help here. I think that all what is needed is to set TestInfo::is_disabled_ flag basing on custom user predicate somehow. 
I'll try to revisit it more attentively a bit later, probably I am missed something.


https://reviews.llvm.org/D34744