[PATCH] D34744: [DWARF] - Simplify HandleExpectedError implementation in DWARFDebugInfoTest

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 10:16:10 PDT 2017


zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

lgtm.  I have some other ideas for how to improve this test in the future, but mostly orthogonal to this effort (for example, why can't we just enumerate the cases that we expect to work based on the `TargetRegistry`, and then only run those tests?)

Might be a nice cleanup if you feel like it (or there might be some reason I can't think of why it wouldn't work the way I imagine), but feel free to do it in a follow-up (or not at all, purely optional)


https://reviews.llvm.org/D34744





More information about the llvm-commits mailing list