[PATCH] D34735: [opt-viewer] Add progress indicators (PR33522)

[Adam Nemet via Phabricator via llvm-commits]

anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D34735#795416, @modocache wrote:

> I had seen tqdm, but:
>
> 1. I wasn't sure what you thought about taking on another dependency, so I erred on the safe side of no additional external dependencies


I was hoping we could do it the way the libYAML dependency is handled: use it as an optional library.

> 1. Just printing "N of 1197" is good enough for me, it lets me get some feedback on whether the script is still working hard or whether it's stuck
> 
>   Up to you, though! Happy to rewrite this with tqdm. My personal preference would be to merge as-is, and if someone wants to make a nicer-looking progress bar they're free to use tqdm.

I am cool with that.  LGTM then ;).


https://reviews.llvm.org/D34735