[PATCH] D34735: [opt-viewer] Add progress indicators (PR33522)

[Simon Whittaker via Phabricator via llvm-commits]

simon.f.whittaker added a comment.

In https://reviews.llvm.org/D34735#795416, @modocache wrote:

> I had seen tqdm, but:
>
> 1. I wasn't sure what you thought about taking on another dependency, so I erred on the safe side of no additional external dependencies
> 2. Just printing "N of 1197" is good enough for me, it lets me get some feedback on whether the script is still working hard or whether it's stuck
>
>   Up to you, though! Happy to rewrite this with tqdm. My personal preference would be to merge as-is, and if someone wants to make a nicer-looking progress bar they're free to use tqdm.


I'd probably err on the side of fewer dependencies also. Within PlayStation we're considering distributing these scripts to end-users (as a stop-gap until something we could possibly do something better with the YAML) so each additional dependency adds some pain.

FWIW I tested the change on Windows also (against Python 2.7.13 only) and it works fine.

Thanks for the work.

Simon


https://reviews.llvm.org/D34735