[PATCH] D33894: Align definition of DW_OP_plus with DWARF spec [3/3]

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 09:29:09 PDT 2017

sdesmalen added inline comments.

Comment at: test/Bitcode/DIExpression-deref.ll:18
 !7 = !DIExpression(DW_OP_deref, DW_OP_plus, 0)
-; CHECK: !DIExpression(DW_OP_plus, 1, DW_OP_deref)
+; CHECK: !DIExpression(DW_OP_plus_uconst, 1, DW_OP_deref)
 !8 = !DIExpression(DW_OP_plus, 1, DW_OP_deref)
aprantl wrote:
> Please also add a test for the old DW_OP_minus. (If you choose to add it to this testcase, you will need to check out a much older version of llvm, rebuild llvm-dis, and re-create the .bc file with it. Otherwise you can add a new upgrade test just for DW_OP_minus and assemble it with today's trunk).
Good spot, I'll add a test for the DW_OPminus too.

In order for me to do that, what is the preferred way get changes to binary files as a patch file that I can upload to Phabricator?
When I tried this previously (having creating a patch file using 'git diff --binary'), Phabricator was not able to parse the patch file.


More information about the llvm-commits mailing list