[PATCH] D33894: Align definition of DW_OP_plus with DWARF spec [3/3]

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

This generally LGTM, there is only a bitcode upgrade test for DW_OP_minus missing. I'm marking the review as accepted under the condition that the missing test is added before committing.



================
Comment at: test/Bitcode/DIExpression-deref.ll:18
 !7 = !DIExpression(DW_OP_deref, DW_OP_plus, 0)
-; CHECK: !DIExpression(DW_OP_plus, 1, DW_OP_deref)
+; CHECK: !DIExpression(DW_OP_plus_uconst, 1, DW_OP_deref)
 !8 = !DIExpression(DW_OP_plus, 1, DW_OP_deref)
----------------
Please also add a test for the old DW_OP_minus. (If you choose to add it to this testcase, you will need to check out a much older version of llvm, rebuild llvm-dis, and re-create the .bc file with it. Otherwise you can add a new upgrade test just for DW_OP_minus and assemble it with today's trunk).


https://reviews.llvm.org/D33894