[PATCH] D33114: [AMDGPU] Turn on the new waitcnt insertion pass. Adjust tests.

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: lib/Target/AMDGPU/DSInstructions.td:442
+let Uses = [EXEC], mayLoad = 1, mayStore = 0, isConvergent = 1 in {
 def DS_SWIZZLE_B32 : DS_1A_RET <"ds_swizzle_b32">;
 }
----------------
rampitec wrote:
> I'm not really sure mayLoad is a correct flag here.
The LGKM_CNT flag indicates that the instruction updates the count so you shouldn't need to rely on isLoad.    Look for this comment in the pass:

  // TODO: Use the (TSFlags & SIInstrFlags::LGKM_CNT) property everywhere.



https://reviews.llvm.org/D33114