[PATCH] D33114: [AMDGPU] Turn on the new waitcnt insertion pass. Adjust tests.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/DSInstructions.td:442
+let Uses = [EXEC], mayLoad = 1, mayStore = 0, isConvergent = 1 in {
 def DS_SWIZZLE_B32 : DS_1A_RET <"ds_swizzle_b32">;
 }
----------------
I'm not really sure mayLoad is a correct flag here.


================
Comment at: lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1865
+  if (!MFI->isEntryFunction()) {
+    // Wait for any outstanding memory operations that the input registers may
+    // depend on. We can't track them and it's better to to the wait after the
----------------
We do not have call support, how this code is triggered?


https://reviews.llvm.org/D33114