[llvm] r303494 - COFF: Fix another StringRef return error

[David Blaikie via llvm-commits]

Do you need the explicit "StringRef()" around the Err.str() expression? Why?

On Sat, May 20, 2017 at 2:54 PM Martell Malone via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: martell
> Date: Sat May 20 16:54:15 2017
> New Revision: 303494
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303494&view=rev
> Log:
> COFF: Fix another StringRef return error
>
> This should appease the lld build bot regression
> Following up on rL303493
>
> Modified:
>     llvm/trunk/lib/Object/COFFModuleDefinition.cpp
>
> Modified: llvm/trunk/lib/Object/COFFModuleDefinition.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/COFFModuleDefinition.cpp?rev=303494&r1=303493&r2=303494&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Object/COFFModuleDefinition.cpp (original)
> +++ llvm/trunk/lib/Object/COFFModuleDefinition.cpp Sat May 20 16:54:15 2017
> @@ -60,7 +60,7 @@ static bool isDecorated(StringRef Sym) {
>  }
>
>  static Error createError(const Twine &Err) {
> -  return make_error<StringError>(Err.getSingleStringRef(),
> +  return make_error<StringError>(StringRef(Err.str()),
>                                   object_error::parse_failed);
>  }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170522/16210620/attachment.html>