<div dir="ltr">Do you need the explicit "StringRef()" around the Err.str() expression? Why?</div><br><div class="gmail_quote"><div dir="ltr">On Sat, May 20, 2017 at 2:54 PM Martell Malone via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: martell<br>
Date: Sat May 20 16:54:15 2017<br>
New Revision: 303494<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=303494&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=303494&view=rev</a><br>
Log:<br>
COFF: Fix another StringRef return error<br>
<br>
This should appease the lld build bot regression<br>
Following up on rL303493<br>
<br>
Modified:<br>
    llvm/trunk/lib/Object/COFFModuleDefinition.cpp<br>
<br>
Modified: llvm/trunk/lib/Object/COFFModuleDefinition.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/COFFModuleDefinition.cpp?rev=303494&r1=303493&r2=303494&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/COFFModuleDefinition.cpp?rev=303494&r1=303493&r2=303494&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Object/COFFModuleDefinition.cpp (original)<br>
+++ llvm/trunk/lib/Object/COFFModuleDefinition.cpp Sat May 20 16:54:15 2017<br>
@@ -60,7 +60,7 @@ static bool isDecorated(StringRef Sym) {<br>
 }<br>
<br>
 static Error createError(const Twine &Err) {<br>
-  return make_error<StringError>(Err.getSingleStringRef(),<br>
+  return make_error<StringError>(StringRef(Err.str()),<br>
                                  object_error::parse_failed);<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>