[PATCH] D33382: [PartialInlining] introduce an internal option to add partial inlining pass in the pipeline (off by default for now)

[Xinliang David Li via llvm-commits]

On Mon, May 22, 2017 at 9:25 AM, Davide Italiano via Phabricator <
reviews at reviews.llvm.org> wrote:

> davide accepted this revision.
> davide added a comment.
> This revision is now accepted and ready to land.
>
> I'm not entirely sure whether you need `cl::ZeroOrMore`. Few comments,
> with that, LG.
> Feel free to submit once addressed without another round trip.
>

It allows the option to be specified multiple times on the  command line
(usually done by build system as ninja).

David


>
> Thanks!
>
>
>
> ================
> Comment at: lib/Passes/PassBuilder.cpp:153-156
> +static cl::opt<bool>
> +RunPartialInlining("npm-partial-inlining", cl::init(false),
> +                   cl::Hidden, cl::ZeroOrMore,
> +                   cl::desc("Run Partial inlinining pass"));
> ----------------
> For consistency with other options (i.e. GVNHoist), I'd use `enable-npm-*`
>
>
> ================
> Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:47-50
> +RunPartialInlining("partial-inlining", cl::init(false),
> +                   cl::Hidden, cl::ZeroOrMore,
> +                   cl::desc("Run Partial inlinining pass"));
> +
> ----------------
> Same here, `enable-partial-inlining`.
>
>
> https://reviews.llvm.org/D33382
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170522/60b39089/attachment.html>