<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 22, 2017 at 9:25 AM, Davide Italiano via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">davide accepted this revision.<br>
davide added a comment.<br>
This revision is now accepted and ready to land.<br>
<br>
I'm not entirely sure whether you need `cl::ZeroOrMore`. Few comments, with that, LG.<br>
Feel free to submit once addressed without another round trip.<br></blockquote><div><br></div><div>It allows the option to be specified multiple times on the  command line (usually done by build system as ninja). </div><div><br></div><div>David</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks!<br>
<br>
<br>
<br>
================<br>
Comment at: lib/Passes/PassBuilder.cpp:<wbr>153-156<br>
+static cl::opt<bool><br>
+RunPartialInlining("npm-<wbr>partial-inlining", cl::init(false),<br>
<span class="">+                   cl::Hidden, cl::ZeroOrMore,<br>
</span>+                   cl::desc("Run Partial inlinining pass"));<br>
----------------<br>
For consistency with other options (i.e. GVNHoist), I'd use `enable-npm-*`<br>
<br>
<br>
================<br>
Comment at: lib/Transforms/IPO/<wbr>PassManagerBuilder.cpp:47-50<br>
<span class="">+RunPartialInlining("partial-<wbr>inlining", cl::init(false),<br>
+                   cl::Hidden, cl::ZeroOrMore,<br>
</span>+                   cl::desc("Run Partial inlinining pass"));<br>
+<br>
----------------<br>
Same here, `enable-partial-inlining`.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D33382" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D33382</a><br>
<br>
<br>
<br>
</blockquote></div><br></div></div>