[PATCH] D33229: [BinaryStream] Simplify the process of using BinaryStreams

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

This makes things shorter, but it does it by using templates to forward constructor arguments. Do we really want to do that? Is there some way we can simplify this code by removing some of the overlapping stream concepts instead?



================
Comment at: llvm/lib/Support/BinaryStreamRef.cpp:18
+
+class ArrayRefBinaryStreamRefImpl : public BinaryStream {
+public:
----------------
Do we really need two refs? ArrayRef is already a pretty crappy name for a non-owning array. In general, can we have four word class names, max?


https://reviews.llvm.org/D33229